Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin numpy #915

Closed
DominicOram opened this issue Nov 25, 2024 · 1 comment · Fixed by #963
Closed

Unpin numpy #915

DominicOram opened this issue Nov 25, 2024 · 1 comment · Fixed by #963
Assignees
@shihab-dls
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Contributor

bluesky/ophyd-async#387 is now closed. We should unpin numpy and confirm that everything still works.

Acceptance Criteria

  • Numpy is unpinned
  • Tests still pass on dodal and on mx-bluesky
@DominicOram
Copy link
Contributor Author

bluesky version 1.13 is currently pinned to numpy<2.0 but the latest version (after bluesky/bluesky@6a25897 will not be)

@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Nov 25, 2024
@DominicOram DominicOram added the good first issue Good for newcomers label Nov 25, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Nov 28, 2024
@rtuck99 rtuck99 mentioned this issue Dec 13, 2024
Closed
@shihab-dls shihab-dls self-assigned this Dec 16, 2024
@shihab-dls shihab-dls mentioned this issue Dec 16, 2024
Merged
4 tasks
@shihab-dls shihab-dls moved this from Todo This Sprint to Review in Hyperion Dec 18, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shihab-dls shihab-dls

Labels
good first issue Good for newcomers
Projects
Hyperion
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpin numpy DiamondLightSource/dodal
2 participants
@DominicOram @shihab-dls