Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin numpy #963

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Unpin numpy #963

merged 3 commits into from
Dec 19, 2024

Conversation

shihab-dls
Copy link
Contributor

Fixes #915

Instructions to reviewer on how to test:

  1. Tests still pass in dodal and bluesky
  2. Both dodal and bluesky have numpy unpinned

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@shihab-dls shihab-dls requested a review from a team as a code owner December 16, 2024 10:11
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.42%. Comparing base (c5c2639) to head (93a928c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #963   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         143      143           
  Lines        6087     6087           
=======================================
  Hits         5930     5930           
  Misses        157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shihab-dls shihab-dls changed the title Unpinning numpy Unpin numpy Dec 16, 2024
pyproject.toml Outdated Show resolved Hide resolved
@DiamondJoseph DiamondJoseph self-assigned this Dec 19, 2024
@shihab-dls shihab-dls merged commit 124b690 into main Dec 19, 2024
19 checks passed
@shihab-dls shihab-dls deleted the 915_unpin_numpy branch December 19, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin numpy
2 participants