Use separate aperture and scatterguard moves #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
==========================================
+ Coverage 85.31% 85.54% +0.23%
==========================================
Files 101 102 +1
Lines 6726 6913 +187
==========================================
+ Hits 5738 5914 +176
- Misses 988 999 +11
|
Closed
DominicOram
requested review from
rtuck99,
noemifrisina,
d-perl and
olliesilvester
rtuck99
reviewed
Jan 2, 2025
| @@ -315,7 +315,7 @@ def test_read_hardware_for_ispyb_updates_from_ophyd_devices( | |||
| # fmt: on | |||
|
|
|||
| @patch( | |||
| "dodal.devices.aperturescatterguard.ApertureScatterguard._safe_move_within_datacollection_range", | |||
| "dodal.devices.aperturescatterguard._safe_move_whilst_in_beam", | |||
There was a problem hiding this comment.
The assert_event in the previous line needs updating for the new underscored device names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
Requires DiamondLightSource/dodal#932
To test