Use production grid detection plan in unit tests #721
Merged
+39
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 16, 2024 17:25
shihab-dls
commented
Dec 18, 2024
tests/unit_tests/hyperion/experiment_plans/test_grid_detect_then_xray_centre_plan.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 86.97% 86.97%
=======================================
Files 101 101
Lines 6933 6933
=======================================
Hits 6030 6030
Misses 903 903
|
tests/unit_tests/hyperion/experiment_plans/test_grid_detect_then_xray_centre_plan.py
Outdated
Show resolved
Hide resolved
rtuck99
reviewed
Dec 20, 2024
tests/unit_tests/hyperion/experiment_plans/test_grid_detect_then_xray_centre_plan.py
Outdated
Show resolved
Hide resolved
|
I've just pushed a commit with an outline sketch of what I think is a better way setup the test fixtures, that should make it more robust and enable more reuse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #611, where references to
_fake_grid_detectionhave been removed and replaced with logic that runs the real grid detection plan.