-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select aperture based on bounding box size #724
Merged
shihab-dls
merged 9 commits into
main
from
618_aperture_selection_based_on_real_box_size
Jan 8, 2025
Merged
Select aperture based on bounding box size #724
shihab-dls
merged 9 commits into
main
from
618_aperture_selection_based_on_real_box_size
Jan 8, 2025
+39
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 86.97% 86.96% -0.01%
==========================================
Files 101 101
Lines 6933 6929 -4
==========================================
- Hits 6030 6026 -4
Misses 903 903
|
rtuck99
reviewed
Dec 20, 2024
src/mx_bluesky/hyperion/experiment_plans/change_aperture_then_move_plan.py
Outdated
Show resolved
Hide resolved
rtuck99
reviewed
Dec 20, 2024
src/mx_bluesky/hyperion/experiment_plans/change_aperture_then_move_plan.py
Outdated
Show resolved
Hide resolved
rtuck99
reviewed
Dec 20, 2024
src/mx_bluesky/hyperion/experiment_plans/change_aperture_then_move_plan.py
Outdated
Show resolved
Hide resolved
rtuck99
reviewed
Dec 20, 2024
tests/system_tests/hyperion/test_aperturescatterguard_system.py
Outdated
Show resolved
Hide resolved
rtuck99
requested changes
Dec 20, 2024
tests/system_tests/hyperion/test_aperturescatterguard_system.py
Outdated
Show resolved
Hide resolved
rtuck99
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #618, where a fixed
grid_width
was assumed and used to calculate how many 'boxes' (i.e., a grid box) a bounding box would occupy, affecting the aperture size required.After conversations with Ollie and Rob, the intended behavior was decided to be changing the aperture based on the size of a bounding box in millimeters, requiring a size of < 0.05mm to select medium aperture. Here, 'bounding box size' solely considers the x-component of a three-dimensional bounding box.
This removed the need for any conversions based on grid boxes.