Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select aperture based on bounding box size #724

Merged
merged 9 commits into from
Jan 8, 2025

Conversation

shihab-dls
Copy link
Collaborator

This addresses #618, where a fixed grid_width was assumed and used to calculate how many 'boxes' (i.e., a grid box) a bounding box would occupy, affecting the aperture size required.

After conversations with Ollie and Rob, the intended behavior was decided to be changing the aperture based on the size of a bounding box in millimeters, requiring a size of < 0.05mm to select medium aperture. Here, 'bounding box size' solely considers the x-component of a three-dimensional bounding box.

This removed the need for any conversions based on grid boxes.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.96%. Comparing base (fc9a053) to head (50b0ff6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   86.97%   86.96%   -0.01%     
==========================================
  Files         101      101              
  Lines        6933     6929       -4     
==========================================
- Hits         6030     6026       -4     
  Misses        903      903              
Components Coverage Δ
i24 SSX 72.69% <ø> (ø)
hyperion 96.54% <100.00%> (-0.01%) ⬇️
other 96.56% <ø> (ø)

@rtuck99 rtuck99 self-requested a review January 6, 2025 14:24
Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Approved

@shihab-dls shihab-dls merged commit cc6408b into main Jan 8, 2025
22 checks passed
@shihab-dls shihab-dls deleted the 618_aperture_selection_based_on_real_box_size branch January 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants