Add readme for greet module #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodgear
force-pushed
the
feat/add-readme
branch
from
5f83ea1
to
7fcd628
Compare
Diegovsky
requested changes
Feb 16, 2023
There was a problem hiding this comment.
LGTM, minor comments: you should Capitalize Your Titles for a more professional feel. Also, would you mind chaging the Makefile to reflect that TARGET_FOLDER variable? I'm still working on the project as a whole to be more usable, so my scripts are looking very amateur-ish
Thank you for the interest in the project :)
woodgear
force-pushed
the
feat/add-readme
branch
from
7fcd628
to
03dcc0d
Compare
|
infact TARGET_FOLDER is in makefile already, it has the default value /usr/lib/zsh/5.9/. but in different distros or different zsh version it in different location, such as me , it is in /usr/lib/x86_64-linux-gnu/zsh/5.8. |
woodgear
force-pushed
the
feat/add-readme
branch
from
03dcc0d
to
b24f393
Compare
|
Fixed the title myself. Could you take a look at the Makefile? I'm 99% sure having |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.