Skip to content

Commit

Permalink
Small CI improvements (#15)
Browse files Browse the repository at this point in the history
As mentioned in the GitHub Actions documentation:

> Avoid using always for any task that could suffer from a critical
> failure, for example: getting sources, otherwise the workflow may
> hang until it times out. If you want to run a job or step
> regardless of its success or failure, use the recommended
> alternative: `if: ${{ !cancelled() }}`

(Description shamelessly copied from my colleague,
Martijn Bastiaan <[email protected]>)
  • Loading branch information
DigitalBrains1 authored May 17, 2024
1 parent a7c365a commit 10d7e6d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,15 @@ jobs:
key: ${{ steps.cache.outputs.cache-primary-key }}

- name: Build
run: cabal v2-build all
run: cabal v2-build all --enable-tests

- name: Test
run: cabal v2-run unittests
run: cabal v2-test --test-show-details=direct

# Mechanism copied from https://github.com/clash-lang/clash-compiler/
all:
name: All jobs finished
if: always()
if: ${{ !cancelled() }}
needs:
- cabal
- stack
Expand Down

0 comments on commit 10d7e6d

Please sign in to comment.