Various CI improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DigitalBrains1
force-pushed
the
only-all-check-required
branch
10 times, most recently
from
1e36376 to
202c106
Compare
DigitalBrains1
changed the title
all test is the only required test
By making only the `all` test a required status check for merging to `main` on GitHub, we can just use the `needs` of that test to determine which CI jobs are required.
The documentation for the `haskell/actions/setup` action demonstrated a nice improvement to caching, where a cache is created even if the project itself fails to build. It also demonstrated cache invalidation based on hashes of all the dependencies, which improves caching efficiency. Also pass `--pedantic` to `stack build` and don't invoke `cabal v2-update` unnecesarily (it's already done by the setup action)
The `.ci` directory contains `stack.yaml` files for each GHC version we test with Stack on CI. These files used to be named after the full GHC version, which is annoying if you want to bump to a later minor version. The files are now named only after the major GHC version so the file doesn't change name on such a bump.
DigitalBrains1
force-pushed
the
only-all-check-required
branch
from
202c106 to
65f5671
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI
alljob checksneedsjob failuresBy making only the
alltest a required status check for merging tomainon GitHub, we can just use theneedsof that test to determine which CI jobs are required.Update GitHub actions
Better caching
The documentation for the
haskell/actions/setupaction demonstrated a nice improvement to caching, where a cache is created even if the project itself fails to build. It also demonstrated cache invalidation based on hashes of all the dependencies, which improves caching efficiency.Pass
--pedantictostack buildand don't invokecabal v2-updateunnecesarily (it's already done by the setup action)Simplify Stack version bumps
The
.cidirectory containsstack.yamlfiles for each GHC version we test with Stack on CI. These files used to be named after the full GHC version, which is annoying if you want to bump to a later minor version. The files are now named only after the major GHC version so the file doesn't change name on such a bump.Minor improvements