Tighten lower bounds, loosen upper bounds #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DigitalBrains1
force-pushed
the
test-bounds
branch
from
ba8ade9 to
991cf48
Compare
We now explicitly test in CI the lower and upper bounds in our `build-depends`. The PvP allows incrementing just the minor version of a package in the case of an API addition. Testing the lower bounds explicitly assures we don't accidentally rely on an API addition made in a minor version. Attempting to test this case revealed our existing lower bounds could not be tested because it did not lead to a valid build plan. So the bounds have been tightened to specify a minor version that we can actually test. We can loosen our upper bounds to include the newest versions of `text` and `tasty` by testing this configuration with cabal's `allow-newer`.
DigitalBrains1
force-pushed
the
test-bounds
branch
from
991cf48 to
1988576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now explicitly test in CI the lower and upper bounds in our
build-depends.The PvP allows incrementing just the minor version of a package in the case of an API addition. Testing the lower bounds explicitly assures we don't accidentally rely on an API addition made in a minor version.
Attempting to test this case revealed our existing lower bounds could not be tested because it did not lead to a valid build plan. So the bounds have been tightened to specify a minor version that we can actually test.
We can loosen our upper bounds to include the newest versions of
textandtastyby testing this configuration with cabal'sallow-newer.