Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using M2 Macbook Air on MacOS Sonoma Version 14.1.1
Discord stable 319436 (45a1ed0)
Host 0.0.315 arm64
Build Override: N/A
macOS 14 (23.1.0)
Purpose
Margin issue where the server list is off-set from the rest of the application on macos (see top-left).
Process to debug & Issues Encountered
I tried looking at the DOM through developer tools. I just found a weird class called:
I narrowed it down to this class. However, after long search I was unable to find out the exact wrapper class anywhere in the code. As such, I was unable to figure out where/if/how the margin was calculated. Not sure if it's a class that's made by discord or something. It's something to look into, but something I'd need help with, if possible.
I did notice that when I unchecked the css class in developer tools, it went back to looking normal:
Solution
I edited
os/_mac.scss
to add one css class called.wrapper_fea3ef
and set the margin-top to zero. It solved the issue, but might be something we'd want to look further into.I also later (not shown) ended up adding another 10px in
_root.scss
just to make it look better.--window-padding: 30px; /* Spacing around the Discord window | DEFAULT: 20px */
Before
After
Thank you for all the hard work maintaining the code for FrostedGlass - it's valued and much appreciated!