Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GitHub CODEOWNERS using the existing PR review teams #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

das-g
Copy link
Member

@das-g das-g commented Apr 30, 2019

(analogous to DjangoGirls/tutorial#1515)

Yes, for this repo (DjangoGirls/tutorial-extensions) this means that there are patterns that don't match any existing directories (yet). I'm assuming that if these translations will be added in the future, the corresponding directory names as in DjangoGirls/tutorial will be used.

using the existing PR review teams from https://github.com/orgs/DjangoGirls/teams
@das-g das-g requested a review from a team April 30, 2019 23:40
@das-g
Copy link
Member Author

das-g commented Sep 21, 2024

GitHub reports errors of the form

Unknown owner on line &ltn>: make sure the team @DjangoGirls/<language code>-pr exists, is publicly visible, and has write access to the repository

on my suggested CODEOWNERS content. Do we need to give those teams more permissions to make these code-ownerships work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant