-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix null DataList
issue + other null-safety concerns
#86
Open
pierrea
wants to merge
9
commits into
Dn-a:null-safety
Choose a base branch
from
pierrea:null-safety
base: null-safety
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6c09e24
make sure itemCount isn't null
pierrea 31a34f4
datalist may be null
pierrea 988046f
make list nullable and fix subsequent errors
pierrea ae85285
v1.0.1
pierrea dc054f6
remove warnings relative to null-safety
pierrea 76bb2e9
version 0.4.10
pierrea 9944afa
revert java
pierrea 0270342
revert example local properties
pierrea 56f31f6
revert example ios
pierrea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1 @@ | ||
import 'package:flutter/material.dart'; | ||
|
||
void main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
import 'package:flutter/material.dart'; | ||
import 'package:flutter_tags/src/suggestions_textfield.dart'; | ||
|
||
import '../flutter_tags.dart'; | ||
import 'util/custom_wrap.dart'; | ||
import 'package:flutter_tags/src/suggestions_textfield.dart'; | ||
|
||
///ItemBuilder | ||
typedef Widget ItemBuilder(int index); | ||
|
@@ -25,11 +25,6 @@ class Tags extends StatefulWidget { | |
this.textField, | ||
Key? key}) | ||
: assert(itemCount >= 0), | ||
assert(alignment != null), | ||
assert(runAlignment != null), | ||
assert(direction != null), | ||
assert(verticalDirection != null), | ||
assert(textDirection != null), | ||
super(key: key); | ||
|
||
///specific number of columns | ||
|
@@ -87,9 +82,9 @@ class TagsState extends State<Tags> { | |
Orientation _orientation = Orientation.portrait; | ||
double _width = 0; | ||
|
||
final List<DataList> _list = []; | ||
final List<DataList?> _list = []; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here is the fix to #79 |
||
|
||
List<Item> get getAllItem => _list.toList(); | ||
List<Item?> get getAllItem => _list.toList(); | ||
|
||
//get the current width of the screen | ||
void _getWidthContext() { | ||
|
@@ -164,11 +159,11 @@ class TagsState extends State<Tags> { | |
tagsTextField: widget.textField!, | ||
onSubmitted: (String str) { | ||
if (!widget.textField!.duplicates) { | ||
final List<DataList> lst = | ||
final List<DataList?> lst = | ||
_list.where((l) => l != null && l.title == str).toList(); | ||
|
||
if (lst.isNotEmpty) { | ||
lst.forEach((d) => d.showDuplicate = true); | ||
lst.forEach((d) => d!.showDuplicate = true); | ||
return; | ||
} | ||
} | ||
|
@@ -240,7 +235,7 @@ class DataListInherited extends InheritedWidget { | |
required Widget child}) | ||
: super(key: key, child: child); | ||
|
||
final List<DataList>? list; | ||
final List<DataList?>? list; | ||
final bool? symmetry; | ||
final int? itemCount; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid use of
!
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks but my IDE complains when using
whereNotNull
, as if it didn't exist...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, it is an extension method from the collection package and it is not used in this package, I'm sorry. (and sorry for the very long delay)