sampling does not typically create variants #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampling random numbers creates variants only if seed is determined by variant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
<sampleRandomNumbers>and<samplePrimeNumbers>under the typical use case where thevariantDeterminesSeedattribute is not set. In this case, these "sample" component no longer create variants. This is the correct behavior because there is no interaction between the sampled numbers and the variants. The previous behavior was confusing as these components created variants even though there was no difference between the variants.If the
variantDeterminesSeedattribute is set, then the sampled numbers do depend on the variants, and the old behavior is maintained.To allow the detection of the value of
variantDeterminesSeedbefore components are created, the attribute can now accept only the literal values "true" or "false"; it no longer accepts references to components, as such values could change dynamically.