Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #93

Merged
merged 5 commits into from
Nov 9, 2022
Merged

Fix bugs #93

merged 5 commits into from
Nov 9, 2022

Conversation

shadycuz
Copy link
Member

@shadycuz shadycuz commented Nov 9, 2022

fixes #91, #92, #89

  • Nested Attributes weren't handled correctly because the conversion of CF prop to TF args happened first
  • Fixed failed to render argument stack_name
  • Fixed edge cases when converting a CF type to a search string for finding the matching TF doc file

Added:

  • Ability to handle "Endpoint" nested !GetAtt for RDS DB Instance

@shadycuz shadycuz added bug Something isn't working patch labels Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #93 (299526f) into develop (a265416) will decrease coverage by 0.31%.
The diff coverage is 76.92%.

@@             Coverage Diff             @@
##           develop      #93      +/-   ##
===========================================
- Coverage    73.73%   73.41%   -0.32%     
===========================================
  Files           16       16              
  Lines         1028     1042      +14     
  Branches       148      153       +5     
===========================================
+ Hits           758      765       +7     
- Misses         232      237       +5     
- Partials        38       40       +2     
Flag Coverage Δ
unit 73.41% <76.92%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/cf2tf/convert.py 54.25% <0.00%> (ø)
src/cf2tf/conversion/expressions.py 86.53% <72.00%> (-2.09%) ⬇️
src/cf2tf/terraform/code.py 94.20% <100.00%> (+0.65%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shadycuz shadycuz merged commit 2582aef into develop Nov 9, 2022
@shadycuz shadycuz deleted the fix_bugs branch November 9, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant