Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generating a StackId when rendering a template #397

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dhutchison
Copy link
Collaborator

Adds in a default value for the StackId property and a function to generate a StackId if it is not already set

Fixes #384

@dhutchison dhutchison added bug Something isn't working minor A new feature has been added. labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.82%. Comparing base (f1b9d72) to head (5d8fae1).
Report is 91 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #397      +/-   ##
===========================================
- Coverage    95.00%   94.82%   -0.18%     
===========================================
  Files           11       12       +1     
  Lines          760      850      +90     
  Branches       155      160       +5     
===========================================
+ Hits           722      806      +84     
- Misses          21       24       +3     
- Partials        17       20       +3     
Flag Coverage Δ
unit 94.82% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhutchison dhutchison linked an issue Dec 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor A new feature has been added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sensible default values for placeholders in Template
1 participant