Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/operation invoked report #266

Conversation

deichmab-draeger
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the changelog accordingly.
  • I have added tests to cover my changes.

@deichmab-draeger deichmab-draeger linked an issue Sep 22, 2023 that may be closed by this pull request
2 tasks
@deichmab-draeger deichmab-draeger added the v2 Version 2 is affected label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (cc4857c) 89.14% compared to head (56360be) 89.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   89.14%   89.62%   +0.48%     
==========================================
  Files         112      113       +1     
  Lines       13039    13102      +63     
==========================================
+ Hits        11623    11743     +120     
+ Misses       1416     1359      -57     
Files Coverage Δ
src/sdc11073/consumer/consumerimpl.py 91.46% <ø> (ø)
src/sdc11073/loghelper.py 83.33% <100.00%> (+0.69%) ⬆️
src/sdc11073/mdib/consumermdibxtra.py 76.71% <100.00%> (+0.85%) ⬆️
src/sdc11073/mdib/descriptorcontainers.py 97.56% <100.00%> (+0.04%) ⬆️
src/sdc11073/provider/dpwshostedservice.py 99.27% <100.00%> (ø)
.../provider/porttypes/descriptioneventserviceimpl.py 100.00% <100.00%> (ø)
src/sdc11073/provider/porttypes/porttypebase.py 97.24% <100.00%> (ø)
src/sdc11073/provider/porttypes/setserviceimpl.py 97.91% <100.00%> (-0.03%) ⬇️
...c11073/provider/porttypes/stateeventserviceimpl.py 99.03% <100.00%> (+6.65%) ⬆️
...sdc11073/provider/porttypes/waveformserviceimpl.py 100.00% <100.00%> (ø)
... and 20 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/sdc11073/provider/operations.py Outdated Show resolved Hide resolved
src/sdc11073/provider/operations.py Outdated Show resolved Hide resolved
src/sdc11073/provider/operations.py Outdated Show resolved Hide resolved
src/sdc11073/provider/operations.py Outdated Show resolved Hide resolved
src/sdc11073/provider/operations.py Outdated Show resolved Hide resolved
src/sdc11073/roles/product.py Show resolved Hide resolved
src/sdc11073/roles/providerbase.py Outdated Show resolved Hide resolved
src/sdc11073/roles/providerbase.py Outdated Show resolved Hide resolved
src/sdc11073/xml_types/msg_types.py Show resolved Hide resolved
tests/test_operations.py Show resolved Hide resolved
leon1995
leon1995 previously approved these changes Oct 4, 2023
@deichmab-draeger deichmab-draeger linked an issue Oct 4, 2023 that may be closed by this pull request
1 task
@deichmab-draeger deichmab-draeger merged commit 26bd75b into Draegerwerk:master Oct 4, 2023
17 checks passed
@deichmab-draeger deichmab-draeger deleted the fix/OperationInvokedReport branch October 4, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Version 2 is affected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing keyword argument: "ssl_context" operations must return operation targets
2 participants