Skip to content

Commit

Permalink
rework manipulation and mode of operation
Browse files Browse the repository at this point in the history
  • Loading branch information
jannast committed Oct 9, 2023
1 parent d594e12 commit 14d2a46
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 10 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- manipulation SetOperationModeStatusAndSetOperatingMode for combined settings
- manipulation SetModeOfOperationAndSetOperatingMode for combined settings
- manipulation ConveyMetricDemoValues for metrics
- manipulation SetAlertConditionAndAlertSignalActivationState for alert activation states

Expand Down
10 changes: 5 additions & 5 deletions src/t2iapi/combined/combined_requests.proto
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ message SetAlertActivationAndSetOperatingModeRequest {
}

/*
Request to set the status of an operation mode of an enum metric with the given handle to the requested value and
set the @OperatingMode of the operation with the given handle to the requested OperatingMode value.
Request to set the non-exclusive mode of operation represented by an enum metric with the given handle to the
requested value and set the @OperatingMode of the operation with the given handle to the requested OperatingMode value.
*/
message SetOperationModeStatusAndSetOperatingModeRequest {
string metric_descriptor_handle = 1; // handle of the enum metric, which represents the operation mode
t2iapi.metric.OperationModeStatus operation_mode_status = 2; // defines the operation mode status to be applied
message SetModeOfOperationAndSetOperatingModeRequest {
string metric_descriptor_handle = 1; // handle of the enum metric, which represents the mode of operation
t2iapi.metric.ModeOfOperation mode_of_operation = 2; // defines the mode of operation to be applied
string operation_descriptor_handle = 3; // the operation descriptor handle for which the OperatingMode value
// shall be set
t2iapi.operation.OperatingMode operating_mode = 4; // OperatingMode value to be set for the operation
Expand Down
9 changes: 5 additions & 4 deletions src/t2iapi/combined/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,13 @@ service CombinedService {
returns (BasicResponse);

/*
Request to set the status of an operation mode of an enum metric with the given handle to the requested value and
set the @OperatingMode of the operation with the given handle to the requested OperatingMode value.
Request to set the non-exclusive mode of operation represented by an enum metric with the given handle to the
requested value and set the @OperatingMode of the operation with the given handle to the requested OperatingMode
value.
The manipulated states shall be persistent until a next manipulation call or an SDC operation invocation.
If the device is not able to maintain the static states, it shall return RESULT_NOT_SUPPORTED.
*/
rpc SetOperationModeStatusAndSetOperatingMode (
t2iapi.combined.SetOperationModeStatusAndSetOperatingModeRequest)
rpc SetModeOfOperationAndSetOperatingMode (
t2iapi.combined.SetModeOfOperationAndSetOperatingModeRequest)
returns (BasicResponse);
}
10 changes: 10 additions & 0 deletions src/t2iapi/metric/types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ enum OperationModeStatus {
OPERATION_MODE_STATUS_PAUSED = 2; // operation mode is not applied, but available
}

/*
Defines the possible non-exclusive MODE OF OPERATION according to MPKP (11073-10701-2022).
These are represented as an enum metric where the instances of pm:AllowedValue have given pm:Type.
*/
enum ModeOfOperation {
MDC_MODE_OF_OPERATION_ON = 0; // mode of operation is applied

Check failure on line 53 in src/t2iapi/metric/types.proto

View workflow job for this annotation

GitHub Actions / lint-protos

Enum value name "MDC_MODE_OF_OPERATION_ON" should be prefixed with "MODE_OF_OPERATION_".
MDC_MODE_OF_OPERATION_OFF = 1; // mode of operation is not applied, but available

Check failure on line 54 in src/t2iapi/metric/types.proto

View workflow job for this annotation

GitHub Actions / lint-protos

Enum value name "MDC_MODE_OF_OPERATION_OFF" should be prefixed with "MODE_OF_OPERATION_".
MDC_MODE_OF_OPERATION_PAUSED = 2; // mode of operation is not applied, but available

Check failure on line 55 in src/t2iapi/metric/types.proto

View workflow job for this annotation

GitHub Actions / lint-protos

Enum value name "MDC_MODE_OF_OPERATION_PAUSED" should be prefixed with "MODE_OF_OPERATION_".
}

/*
The MetricStatus is intended to reflect the state of the device and is not the ActivationState.
This state in turn should trigger the setting of the ActivationState, it is linked to the
Expand Down

0 comments on commit 14d2a46

Please sign in to comment.