Skip to content

Commit

Permalink
remove ChangeOperationModeStatus manipulation (#71)
Browse files Browse the repository at this point in the history
// remove ChangeOperationModeStatus manipulation

# Checklist

The following aspects have been respected by the author of this pull
request, confirmed by both pull request assignee **and** reviewer:

* Changelog update (necessity checked and entry added or not added
respectively)
  * [x] Pull Request Assignee
  * [x] Reviewer
* README update (necessity checked and entry added or not added
respectively)
  * [x] Pull Request Assignee
  * [x] Reviewer
  • Loading branch information
jannast authored Oct 30, 2023
1 parent 8360b1f commit c76b587
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 28 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- gRPC version to 1.58.0
- protoc version to 24.1

### Removed

- manipulation ChangeOperationModeStatus for metrics

## [3.0.0] - 2023-09-11

### Added
Expand Down
8 changes: 0 additions & 8 deletions src/t2iapi/metric/metric_requests.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,6 @@ message SetMetricValuesInRangeRequest {
string upper = 3; // upper limit for setting the new pm:MetricValue/@Value or @Samples
}

/*
Request to change the status of an operation mode.
*/
message ChangeOperationModeStatusRequest {
string handle = 1; // handle of the enum metric, which represents the operation mode
OperationModeStatus operation_mode_status = 2; // defines if the operation mode status shall be applied
}

/*
Request a change of the status of a metric.
*/
Expand Down
11 changes: 0 additions & 11 deletions src/t2iapi/metric/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,6 @@ service MetricService {
rpc SetMetricValuesInRange (t2iapi.metric.SetMetricValuesInRangeRequest)
returns (BasicResponse);

/*
Change the status of an operation mode.
An operation mode represents a specific behaviour of a device that can be enabled, paused or disabled,
typically by the user.
BICEPS does not provide a model element out of the box that can be used for such a mode, thus the operation mode
is represented by a pm:EnumStringMetricDescriptor, as described by MPKP draft.
*/
rpc ChangeOperationModeStatus (t2iapi.metric.ChangeOperationModeStatusRequest)
returns (BasicResponse);

/*
Set the provided measurement, calculation or setting status for the metric of the provided handle. This is not the
AbstractMetricState/@ActivationState, but the internal state of the device.
Expand Down
9 changes: 0 additions & 9 deletions src/t2iapi/metric/types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,6 @@ enum GenerationMode{
GENERATION_MODE_DEMO = 2;
}

/*
Defines the possible operation mode states according to MPKP draft.
*/
enum OperationModeStatus {
OPERATION_MODE_STATUS_ON = 0; // operation mode is applied
OPERATION_MODE_STATUS_OFF = 1; // operation mode is not applied, but available
OPERATION_MODE_STATUS_PAUSED = 2; // operation mode is not applied, but available
}

/*
Defines the possible non-exclusive MODE OF OPERATION according to MPKP (11073-10701-2022).
These are represented as an enum metric where the instances of pm:AllowedValue have the pm:Type of:
Expand Down

0 comments on commit c76b587

Please sign in to comment.