Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new manipulation get available meta data #84

Merged

Conversation

pstaeck
Copy link
Collaborator

@pstaeck pstaeck commented Jun 17, 2024

The purpose of the pull request is to have a manipulation that returns the device meta data that must be available.

Checklist

The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer:

  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer
  • README update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer

@pstaeck pstaeck requested review from ldeichmann and belagertem June 17, 2024 09:38
@pstaeck pstaeck self-assigned this Jun 17, 2024
src/t2iapi/device/types.proto Outdated Show resolved Hide resolved
src/t2iapi/device/types.proto Outdated Show resolved Hide resolved
src/t2iapi/biceps/codedvalue.proto Outdated Show resolved Hide resolved
src/t2iapi/biceps/codedvalue.proto Outdated Show resolved Hide resolved
src/t2iapi/biceps/codedvalue.proto Outdated Show resolved Hide resolved
src/t2iapi/biceps/localizedtext.proto Outdated Show resolved Hide resolved
src/t2iapi/biceps/localizedtext.proto Outdated Show resolved Hide resolved
src/t2iapi/biceps/instanceidentifier.proto Outdated Show resolved Hide resolved
src/t2iapi/biceps/instanceidentifier.proto Outdated Show resolved Hide resolved
src/t2iapi/biceps/localizedtext.proto Outdated Show resolved Hide resolved
@pstaeck pstaeck requested a review from ldeichmann July 1, 2024 10:15
belagertem
belagertem previously approved these changes Jul 3, 2024
Copy link
Member

@ldeichmann ldeichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolved review remarks

src/t2iapi/biceps/localizedtextwidth.proto Outdated Show resolved Hide resolved
src/t2iapi/biceps/metadata.proto Outdated Show resolved Hide resolved
@pstaeck pstaeck merged commit 863c4ff into Draegerwerk:main Jul 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants