Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create schema validator for the config file and add to the sample #161

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

GeneralPractitioner-GP
Copy link

@GeneralPractitioner-GP GeneralPractitioner-GP commented Apr 15, 2024

The schema validator can make sure that the fields which are required are present and are of the correct type.

You can test it from my fork by changing the URL to https://raw.githubusercontent.com/GeneralPractitioner-GP/daps/schema-validator/schemas/config-schema.json

It's the first one that I've created outside of testing them out on other projects. Thought it might help those that are confused by what is required.

I tested it on the example and my config file.

Recyclarr has some good docs on how to get it to work
https://recyclarr.dev/wiki/schema-validation/

@Drazzilb08 Drazzilb08 changed the base branch from master to dev April 16, 2024 02:08
@Drazzilb08
Copy link
Owner

Drazzilb08 commented Apr 16, 2024

Sorry I haven't had a chance to look this over. I love the idea and addition to the code. I hope to get to it soon. I've been dumb busy with work, home and medical issues recently but I will soon (I hope)

Edit: I finally got a chance to play with this. I love it..

@Drazzilb08 Drazzilb08 changed the base branch from dev to master April 17, 2024 01:15
@Drazzilb08 Drazzilb08 merged commit 7f07f95 into Drazzilb08:master Apr 17, 2024
@GeneralPractitioner-GP GeneralPractitioner-GP deleted the schema-validator branch April 17, 2024 09:49
@GeneralPractitioner-GP
Copy link
Author

Sorry I haven't had a chance to look this over. I love the idea and addition to the code. I hope to get to it soon. I've been dumb busy with work, home and medical issues recently but I will soon (I hope)

Edit: I finally got a chance to play with this. I love it..

Glad you like it :)
Hope you get better soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants