[chore] fix dropped data item counter #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
dropped_span_countmetric reported in the benchmark results.The high number of dropped spans was reported because for the pull based scenario, the number of sent data items is the static number of metrics exposed via each prometheus endpoint (e.g. 1000), whereas the number of received items is the number of metrics times the number of performed scrape iterations due to the internal mechanics of the testbed validator's benchmark summary this is then recorded as "dropped_span_count".
The name "dropped_span_count" is also misleading here, as this is calculated from the number of generated data items minus the number of received items - which don't have to be spans in each case, but can also be metrics or logs.