Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Commands #89

Open
wants to merge 72 commits into
base: master
Choose a base branch
from
Open

Update Commands #89

wants to merge 72 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 19, 2021

Update

  • Update Dyno RPG Commands
  • Add Profile commands
  • Add Reports Commands

Note

Ignore the create modules commit. I closed that one in favor of using more fitting subfolders.

Copy link
Collaborator

@Swordington Swordington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is of my personal opinion that taking commands from StrandCC, which it turns out is still an active organization, and bringing them into our repo is not an ethical course of action.
On that note, within the RPG module there are also quite a few typos that could use fixing. Please make sure to review the module w/ a spell checker.

@ghost
Copy link
Author

ghost commented Mar 19, 2021

I can check for typos. I didn't see any before but will gladly fix any that are there. As for the strand CC commands I actually removed most of those and am sticking to mostly my own. The profiles is the only one kept and I plan to make my own edits to those tbh.

@ghost ghost requested a review from Swordington March 19, 2021 15:33
@ghost
Copy link
Author

ghost commented Mar 19, 2021

It is of my personal opinion that taking commands from StrandCC, which it turns out is still an active organization, and bringing them into our repo is not an ethical course of action.
On that note, within the RPG module there are also quite a few typos that could use fixing. Please make sure to review the module w/ a spell checker.

Ok I finished going over it all. The Modules folder is the one I chose to remove. Thus the comment about ignoring the create modules commit. As for the StrandCC Commands I actually didn't keep any of those.

I learned from their methods for the setup command and basically made my own setup commands for use with the only three modules I have.

My RPG commands have their own and my reports command has it's own but other than that the Profiles module is one I'm editing over time. I plan to add a set-games command as soon as i get it to accept a different format lol

Copy link
Collaborator

@Swordington Swordington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that overall, it's a great module, and the addition of GIFs is a nice touch. That being said, there are a few things that are really confusing.

  • Avelon RPG or Dyno RPG? I understand that the world is called Avelon, but is the RPG the Avelon RPG?
  • Is it a status ailment or just an ailment? These seem to be used interchangeably throughout the module.
  • Multiline choice and DM? Fairly sure these won't work properly.
  • Adding a {silent} tag will negate the announce.
    I think that overall this is a great module, and just needs a few bits of clarification / touching up to work. I also would love if you made sure that all of these commands were thoroughly tested so that there are no sudden bugs etc.

Fun Commands/Mini-Games/Dyno-RPG/cointoss.txt Show resolved Hide resolved
Fun Commands/Mini-Games/Dyno-RPG/cointoss.txt Outdated Show resolved Hide resolved
Fun Commands/Mini-Games/Dyno-RPG/README.md Show resolved Hide resolved
Fun Commands/Mini-Games/Dyno-RPG/README.md Outdated Show resolved Hide resolved
Fun Commands/Mini-Games/Dyno-RPG/README.md Outdated Show resolved Hide resolved
Fun Commands/Mini-Games/Dyno-RPG/rpg-help.txt Outdated Show resolved Hide resolved
Fun Commands/Mini-Games/Dyno-RPG/rpg-help.txt Outdated Show resolved Hide resolved
Fun Commands/Mini-Games/Dyno-RPG/rpg-help.txt Show resolved Hide resolved
Fun Commands/Mini-Games/Dyno-RPG/treat.txt Show resolved Hide resolved
Fun Commands/Mini-Games/Dyno-RPG/unregister.txt Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Mar 23, 2021

Update 03/22/2021

  • Applied requested fixes.
  • Ready for review.

@ghost ghost requested a review from Swordington March 29, 2021 03:22
 - Fixed a couple minor typos
 - Updated a Death Response
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update 06/11/2021

  • Minor typos spotted and fixed in cointoss.txt
  • Updated one of the Death responses in cointoss.txt
  • Awaiting Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants