-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PMP version #118
base: main
Are you sure you want to change the base?
Update PMP version #118
Conversation
Update pcmdi_metrics version to 3.4.1 in meta.yaml
@lee1043, thanks for the suggestion! We won't have another E3SM-Unified release until November but I have made a note of this change to include it then. There's no problem with keeping this PR open until then but just to note that the change won't happen for a while. |
@xylar thanks. No problem with keeping this PR open, just wanted to leave a note for any future update. |
Update PMP version to the latest
@lee1043, in the latest pcmdi_metrics, you are pinning a specific numpy verison: Much appreciated! |
@xylar thank you for pining me. I recall this numpy version restriction was mostly because of cdms. We are working on removing cdms dependency from PMP, and once completed, I think that will release the numpy version restriction. We are aiming to get this done by mid Jan 2025 to be better aligned with the next E3SM unified env version timeline. Would this work for you? |
@lee1043 that's what I was hoping to hear! Thanks! Also, I patched cdms2 and genutil for numpy 2.0 on Friday so you may want to see how that goes even in the interim before you move away from cdat. |
@xylar that is great to hear, thank you for letting me know! Is the patched cdms2 available through conda channel? |
Please let me know if you run into trouble. I patched every issue I came across but the testing on conda-forge may not cover everything. |
@xylar thank you! I will test it and let you know how it works. Just a note, a while ago I opened an issue on CDMS regarding its conflict with numpy version CDAT/cdms#449, which I believe that must be resolved by your patch. Did I get that right? Is there specific CDMS version number assigned after for your patch? |
I believe that issue was fixed in earlier patches by me: No one is maintaining CDAT so I think your issues are unfortunately being lost in the ether. You could try to make issues on the conda-forge feedstock but I also have really limited time to maintain a dying and very frustrating package. Still, better than nothing... |
Not a version number (that would require the developers to create a new release) but a build number. If you install cdms2 and you have a constraint
The end of the build string ( |
@xylar great to know, thank you! I agree it is not exciting to maintain a dying package. |
@tomvothecoder it looks like the same numpy version issue applies to xcdat (https://github.com/xCDAT/xcdat/blob/96bc649ad59750ec37b959d9d4890891b54c62c7/conda-env/dev.yml#L14) when @xylar plans to upgrade numpy version in E3SM unified. |
Thanks, yes I plan on removing the constraint soon. It was added because xESMF was not compatible with |
Update pcmdi_metrics version to 3.4.1 in meta.yaml