-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update endpoint lgd-publication to support extra data #58
Conversation
…into update/endpoint_lgd_publications
…into update/endpoint_lgd_publications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor suggestion. Thanks @dglemos
gene2phenotype_project/gene2phenotype_app/serializers/publication.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…into update/endpoint_lgd_publications
This reverts commit 91605ea.
This reverts commit 13ea9aa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To insert a new publication the endpoint also allows to insert optional fields:
phenotypes
linked to new and/or existing publicationsvariant types
linked to new and/or existing publicationsvariant descriptions
linked to new and/or existing publicationsmechanism
linked to new and/or existing publications (Note: only "undetermined" mechanisms can be updated)mechanism evidence
linked to new and/or existing publicationsTesting
The input format is the same as the draft json data.
Input example: