Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoint lgd-publication to support extra data #58

Merged
merged 23 commits into from
Dec 5, 2024

Conversation

dglemos
Copy link
Collaborator

@dglemos dglemos commented Oct 23, 2024

To insert a new publication the endpoint also allows to insert optional fields:

  • phenotypes linked to new and/or existing publications
  • variant types linked to new and/or existing publications
  • variant descriptions linked to new and/or existing publications
  • mechanism linked to new and/or existing publications (Note: only "undetermined" mechanisms can be updated)
  • mechanism evidence linked to new and/or existing publications

Testing
The input format is the same as the draft json data.

Input example:

{ "publications":[{
                            "publication": { "pmid": 1234 },
                            "comment": { "comment": "this is a comment", "is_public": 1 },
                            "families": { "families": 2, "consanguinity": "unknown", "ancestries": "african", "affected_individuals": 1    
                         }
                  }],
"phenotypes": [{
                                        "pmid": "1234",
                                        "summary": "",
                                        "hpo_terms": [{ "term": "Orofacial dyskinesia",
                                                        "accession": "HP:0002310",
                                                        "description": "" }]
                                    }],
"variant_types": [{
                                        "comment": "",
                                        "de_novo": false,
                                        "inherited": false,
                                        "nmd_escape": false,
                                        "primary_type": "protein_changing",
                                        "secondary_type": "inframe_insertion",
                                        "supporting_papers": ["1234"],
                                        "unknown_inheritance": true
 }],
"variant_descriptions": [{
                                        "description": "HGVS:c.9Pro",
                                        "publication": "1234"
 }],
"molecular_mechanism": {
        "name": "gain of function",
        "support": "evidence"
      },
      "mechanism_synopsis": {
        "name": "",
        "support": ""
      },
      "mechanism_evidence": [
        {
          "pmid": "1234",
          "description": "This is new evidence for the existing mechanism evidence.",
          "evidence_types": [
            {
              "primary_type": "Function",
              "secondary_type": [
                "Biochemical"
              ]
            }
          ]
        }
      ]
}

@dglemos dglemos changed the title Update endpoint to add lgd/publication to support extra data Update endpoint lgd-publication to support extra data Oct 23, 2024
@dglemos dglemos marked this pull request as ready for review October 30, 2024 16:24
Copy link
Collaborator

@olaaustine olaaustine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestion. Thanks @dglemos

Copy link
Collaborator

@seeta-ramaraju seeta-ramaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@seeta-ramaraju seeta-ramaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seeta-ramaraju seeta-ramaraju merged commit 4be0410 into main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants