Add 2D tests for proton boron fusion #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilZaim
force-pushed
the
ProtonBoron2DTest
branch
from
4d48c48
to
ecb51dd
Compare
NeilZaim
changed the title
ax3l
reviewed
Mar 3, 2022
| proton4.density = 1.e35 | ||
| proton4.momentum_distribution_type = "constant" | ||
| proton4.uz = sqrt(2*m_p*proton4_energy)/(m_p*clight) | ||
| proton4.do_not_push = 1 |
There was a problem hiding this comment.
as in 3D: also let us add do_not_deposit
| ################################# | ||
| ############ NUMERICS ########### | ||
| ################################# | ||
| warpx.serialize_ics = 1 |
Regression/WarpX-tests.ini
Outdated
| [Proton_Boron_Fusion_2D] | ||
| buildDir = . | ||
| inputFile = Examples/Modules/nuclear_fusion/inputs_2d | ||
| runtime_params = |
There was a problem hiding this comment.
Suggested change
| runtime_params = | |
| runtime_params = warpx.do_dynamic_scheduling=0 warpx.serialize_initial_conditions=1 |
NeilZaim
force-pushed
the
ProtonBoron2DTest
branch
from
7e5e039
to
e2cb6dc
Compare
NeilZaim
added
component: tests
RemiLehe
approved these changes
Jul 12, 2022
dpgrote
pushed a commit
to RemiLehe/WarpX
that referenced
this pull request
Jul 30, 2022
* Add 2D tests for proton boron fusion * Apply suggestions from review * Fix WarpX-tests.ini * Update benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #2450, which is based on #2330, so it should probably be reviewed once these PRs have been merged.
It adds the same automated tests as in #2450, but in 2D instead of 3D. The same analysis script is used to analyze both tests, with only minor modifications.
Putting the [WIP] tag until I have tested this on GPU.
Edit: tested on GPU so I'm removing the WIP tag.