-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize differential luminosity for photons #5222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
[WIP] Generalize differential luminosity for photons
Generalize differential luminosity for photons
Sep 7, 2024
RemiLehe
changed the title
Generalize differential luminosity for photons
[WIP] Generalize differential luminosity for photons
Sep 13, 2024
RemiLehe
changed the title
[WIP] Generalize differential luminosity for photons
Generalize differential luminosity for photons
Oct 4, 2024
aeriforme
reviewed
Oct 9, 2024
Examples/Tests/diff_lumi_diag/inputs_test_3d_diff_lumi_diag_photons
Outdated
Show resolved
Hide resolved
aeriforme
approved these changes
Oct 10, 2024
dpgrote
pushed a commit
to dpgrote/WarpX
that referenced
this pull request
Oct 23, 2024
The differential luminosity diagnostic was not valid for particles with mass 0. This PR generalizes the code for photons by expressing the center-of-mass energy with the 4-momentum: <img width="334" alt="Screenshot 2024-09-06 at 9 27 33 PM" src="https://github.com/user-attachments/assets/1100fce4-7043-44f7-91e9-73f6c9272799"> which is valid for photons as well. I also slightly simplified the code that computes the term <img width="244" alt="Screenshot 2024-09-06 at 9 30 45 PM" src="https://github.com/user-attachments/assets/7816da3a-196e-4645-8bc5-aed1bcd897c0"> I also added a test using photons. This is done by extracting an base input script from the existing luminosity test involving **electrons and positrons**, and creating an input script involving photons that leverages the base input script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The differential luminosity diagnostic was not valid for particles with mass 0.
This PR generalizes the code for photons by expressing the center-of-mass energy with the 4-momentum:
which is valid for photons as well.
I also slightly simplified the code that computes the term
I also added a test using photons. This is done by extracting an base input script from the existing luminosity test involving electrons and positrons, and creating an input script involving photons that leverages the base input script.