Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable jenkins HIP CI #735

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Re-enable jenkins HIP CI #735

wants to merge 6 commits into from

Conversation

streeve
Copy link
Member

@streeve streeve commented Jan 29, 2024

No description provided.

@streeve streeve requested a review from dalg24 January 29, 2024 12:25
@streeve streeve self-assigned this Jan 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ef42d2) 96.4% compared to head (462d0c2) 96.4%.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master    #735   +/-   ##
======================================
  Coverage    96.4%   96.4%           
======================================
  Files          92      92           
  Lines       14763   14763           
======================================
  Hits        14240   14240           
  Misses        523     523

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dalg24
dalg24 reviewed Jan 29, 2024
View reviewed changes
docker/Dockerfile.hipcc Outdated
@@ -100,7 +100,7 @@ RUN ARBORX_VERSION=4834bff44c23c9510c6ed93366638dcdf85ab217 && \
-D CMAKE_INSTALL_PREFIX=${ARBORX_DIR} \
-D CMAKE_BUILD_TYPE=Debug \
-D CMAKE_CXX_COMPILER=hipcc \
-D CMAKE_CXX_FLAGS=-amdgpu-target=gfx906 \
-D CMAKE_CXX_FLAGS=-amdgpu-target=gfx908 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait why do we add flags here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we've had that since we added TPL to HIP builds. All the jenkins builds need version/option updates - are you okay if I do that separately?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. You might want (whenever you handle this) to pass -D GPU_TARGETS=gfx908.
This is intended for rocThrust, making sure that it does not make you compile for all AMD GPU architectures that cmake knows about.

@streeve
Copy link
Member Author

streeve commented Jan 29, 2024

retest this please.

@streeve
Copy link
Member Author

streeve commented Jan 30, 2024

retest this please.

1 similar comment
@streeve
Copy link
Member Author

streeve commented Feb 1, 2024

retest this please.

@streeve streeve mentioned this pull request Feb 5, 2024
Merged
@streeve streeve force-pushed the enable_jenkins_hip branch 3 times, most recently from 650fbba to 0889695 Compare February 8, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

Assignees

@streeve streeve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@streeve @dalg24