Add support for Kokkos Remote Spaces 1.2, rebases on top of master #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janciesko
commented
Jun 12, 2024
janciesko
commented
- Updates initial implementation
- Removes Makefile
- Adds more CMake options
- Rebases on top of master
…tion, remove this usage.
….cpp:162:42: warning: more '%' conversions than data arguments [-Wformat]).
…ve been reorganized to be consistent with Kokkos::View. ExaMiniMD not currently using Arg3Type, which if provided corresponds to the MemoryTraits. Because the implementation is not using variadic templates, order of template arguments matters. For now simply passing the default value. May want to use this differently?
…>::team_size_max(Functor) changes to a member function of the team policy. The previous variant didn't take all necessary information into account and could potentially result in invalid answers. NOTE: the league and team size arguments passed to the TeamPolicy may warrant inspection (force_types/force_snap_neigh_impl.h:183), e.g., perhaps use team_scratch_size & thread_scratch_size?
Update ExaMiniMD for Kokkos v3.0 promotion
Original makefile was not removed Cuda needs testing
Build with CMake 3.10+
Changes to allow HIP
This compiles now (leaving out the SNAP potential which requires, ThreadVector level paralle_scan), but fails to do mandatory offload for a couple kernels (sorting, neighborlist construction) in the LJ example.
Atempt to make ExaMiniMD work with OpenMPTarget
Fix running with the SYCL backend
fixup: MPI CMake configure flag typo
Install exe with CMake
Fix compile error
- Removes Makefile - Adds CMake options
Use same li file as CabanaMD Fix ifdefs when using USING_MPI or USING_KOKKOS_REMOTE_SPACES
janciesko
force-pushed
the
remote-spaces
branch
8 times, most recently
from
5e1dbc9
to
7fa5915
Compare
Add force module that uses KRS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.