-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peatlands pull request #310
Open
larsonej
wants to merge
20
commits into
EDmodel:master
Choose a base branch
from
larsonej:peatpr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks soil carbon in vertically resolved manner. Also has height dependent mortality. Plus many small changes and bug fixes.
…n be turned on/off in ED2IN
… due to type of logical expression?
…ition from peat to mineral (loam) soil.
… transitional organic layers to soil colour.
…eased snow density to account for compaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The general goal of these code changes is to vertically resolve the soil carbon in areas that have a lot of carbon, such as peatlands and arctic permafrost. The carbon cycle in these areas is sensitive to the amount and type of carbon susceptible to decomposition. This is generally the carbon above the water table and thawed. The major code changes involved two aspects, 1) allowing the soil carbon to be vertically resolved, and 2) making soil properties a function of the soil carbon. Along with these two major changes, there were some small changes as well.
Collaborators
Motivation and Context
Types of changes
Checklist:
Testing :