Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.1] code polishing: tools/filter.py #205

Merged
merged 4 commits into from
Aug 16, 2023
Merged

[v0.1] code polishing: tools/filter.py #205

merged 4 commits into from
Aug 16, 2023

Conversation

trz42
Copy link
Contributor

@trz42 trz42 commented Aug 8, 2023

Code polishing pass on tools/filter.py for release v0.1:

  • imports: same categorisation of imports
  • docstrings: slightly rephrased some + added a missing information
  • comments: improved some comments

boegel
boegel requested changes Aug 8, 2023
View reviewed changes
tools/filter.py Outdated Show resolved Hide resolved
tools/filter.py Outdated Show resolved Hide resolved
tools/filter.py Outdated Show resolved Hide resolved
tools/filter.py Show resolved Hide resolved
tools/filter.py Outdated Show resolved Hide resolved
tools/filter.py Show resolved Hide resolved
tools/filter.py Outdated Show resolved Hide resolved
@boegel boegel merged commit 1f29f96 into EESSI:main Aug 16, 2023
@boegel boegel added this to the 0.1.0 - initial release milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@trz42 @boegel @truib