Work around welcome page disappearing post install #2798
Conversation
|
Related Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1558336 |
|
@ablanathtanalba Thoughts? |
There was a problem hiding this comment.
Looks good to me, just tested in the latest nightly on macOS Big Sur 11.6.
I think 1 minute is a good compromise, some thoughts though; it's about a minute to skim through the welcome page text (as it is now) if they interact with that first before the private windows hanger prompt. I haven't tested on the new welcome page drafts, but it does take more than a minute to read through the content now at a leisurely pace, so there's a small chance people could get be there reading first, get finished, then click the hanger prompt allowing it to run in private windows, and then they're jumped up to the top of the welcome page again. A little wonky, but worth the compromise imo.
|
Yeah, we're probably erring on the side of reopening the welcome page when we shouldn't. Hard to say without user testing, but this should be OK as reopening the welcome page when it's not wanted (at most once) is much less bad than having it close with no recourse. |
Work around welcome page disappearing post install. Happens when the user allows Privacy Badger to run in Private windows using the post-install Private browsing permission hanger in Firefox before reviewing the welcome page. Related Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1558336
|
Note that there was an important followup fix to this workaround: 12fa27f |
This is meant to help Firefox users not lose the welcome page when it gets inadvertently closed when the user chooses to first interact with the post-install Private browsing permission hanger (a reasonable choice) and allows Privacy Badger to run in Private windows.
Related to #2781.
To test:
xpinstall.signatures.requiredtofalseinabout:configcd srcand thenzip -r badger.xpi *about:addons, switch to the Firefox window, click "Add" in the unverified extension promptIf you interact with the welcome page first, finish reading it, and respond to the Private browsing permission hanger in under a minute, we are going to reopen the welcome page, which is a bit annoying.
We could shorten the timer duration, but then we run the opposite risk of not reopening the welcome page if the user took too long to interact with the permission hanger. Is one minute a good compromise?