Device screen UI #46
Merged
Device screen UI #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgreenberg
requested changes
Jun 12, 2024
Co-authored-by: Will Greenberg <[email protected]>
Co-authored-by: Will Greenberg <[email protected]>
wgreenberg
reviewed
Jun 17, 2024
wgreenberg
requested changes
Jun 17, 2024
bin/src/daemon.rs
Outdated
Comment on lines
158
to
163
| 2 => { | ||
| fb.draw_gif(img); | ||
| }, | ||
| 3 => { | ||
| fb.draw_img(img) | ||
| } |
There was a problem hiding this comment.
Suggested change
| 2 => { | |
| fb.draw_gif(img); | |
| }, | |
| 3 => { | |
| fb.draw_img(img) | |
| } | |
| 2 | 3 => { | |
| fb.draw_gif(img.unwrap()); | |
| }, |
There was a problem hiding this comment.
Nope these are separate functions, I have split out draw gif and draw image
There was a problem hiding this comment.
also we arleady unwrap and return a result in 138/140 no?
There was a problem hiding this comment.
OH duh. and img is an Option, so we need to unwrap it again here
Co-authored-by: Will Greenberg <[email protected]>
wgreenberg
reviewed
Jun 17, 2024
Co-authored-by: Will Greenberg <[email protected]>
wgreenberg
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.