-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OBSDEF-35531] [OBSDEF-44979] DataGrid enhancement for predefine page sizes and custom page sizes #272
Merged
netraja-chavan
merged 11 commits into
main
from
feature-OBSDEF-35531-datagrid-enhancement-predefined-pagesizes
Apr 17, 2024
Merged
[OBSDEF-35531] [OBSDEF-44979] DataGrid enhancement for predefine page sizes and custom page sizes #272
netraja-chavan
merged 11 commits into
main
from
feature-OBSDEF-35531-datagrid-enhancement-predefined-pagesizes
Apr 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netraja-chavan
requested review from
akate1,
maheshkulkarni4,
girishdudhe,
ben-schumacher,
ShitalSD,
psivakumaran,
m-manaswini and
Bhatii
as code owners
April 8, 2024 03:49
akate1
reviewed
Apr 8, 2024
akate1
reviewed
Apr 11, 2024
akate1
reviewed
Apr 11, 2024
akate1
reviewed
Apr 14, 2024
akate1
reviewed
Apr 16, 2024
akate1
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AgarwalDeepak89
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:-
https://jira.cec.lab.emc.com/browse/OBSDEF-35531
https://jira.cec.lab.emc.com/browse/OBSDEF-44979
Test link:-
Storybook:- http://10.227.244.41:6006/?path=/story/datagrid--grid-with-pagination-and-default-pagesizes-dropdown
Objectscale:- http://10.227.244.41:3002/#/administration/requests
Note:-
Raising single PR for custom page size and predefined page sizes as these changes are interdependent.