-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submission template #173
submission template #173
Conversation
inst/submission.md
Outdated
|
||
- Who is the target audience and what are scientific applications of this package? | ||
|
||
The target audience of the package are researchers like marine ecologists, that might need EMODnet geographic vector data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe one of you might have a suggestion of a bit more content here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target audience is all EMODnet users, not just researchers and not just marine ecologists, so maybe something more like
"The target audience of the package are EMODnet users that might need EMODnet's geographic vector data "
Should we say something about downloading everything in one go via one query, as opposed to the human interface (e.g. viewer/catalogue) that requires a bit more user interaction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 9 9
Lines 359 359
=======================================
Hits 335 335
Misses 24 24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added the changes @JoBeja suggested at #173 (comment) on 643dd5b
Besides this little change, all good for me! Thanks @maelle 🙌
For your review @salvafern (I won't submit without your feedback and approval 😇 )
For info @annakrystalli @JoBeja (but your feedback is most welcome!)