Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating atmospheric_physics submodule. #318

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

mwaxmonsky
Copy link
Collaborator

@mwaxmonsky mwaxmonsky commented Oct 30, 2024

Tag name (required for release branches):
Originator(s): @mwaxmonsky

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number): Updates atmospheric_physics submodule to enable vertical diffusion solver accessible from submodule.

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: None

List all files added and what they do: None

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M .gitmodules
M src/physics/ncar_ccpp

  • Updates submodule and its directory to latest tagged release to make vertical diffusion solver available directly in SIMA.

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima: All PASS

derecho/gnu/aux_sima: All PASS

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced: N/A

CAM-SIMA date used for the baseline comparison tests if different than latest: N/A

@mwaxmonsky mwaxmonsky self-assigned this Oct 30, 2024
@mwaxmonsky mwaxmonsky marked this pull request as ready for review November 11, 2024 03:10
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mwaxmonsky!

Also just a reminder to run the CAM-SIMA regression tests on derecho as described in the "Testing" section of the CAM-SIMA documentation (and if you have any issues just let me know). Thanks!

@mwaxmonsky
Copy link
Collaborator Author

Looks good, thanks @mwaxmonsky!

Also just a reminder to run the CAM-SIMA regression tests on derecho as described in the "Testing" section of the CAM-SIMA documentation (and if you have any issues just let me know). Thanks!

Thanks @nusbaume! Both Intel and GNU tests all pass with the SUBMIT jobs all stay in a PEND state so it looks like all the builds completed successfully.

@mwaxmonsky mwaxmonsky merged commit 623ef7b into ESCOMP:development Nov 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants