Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): peverwhee
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
inverse_exner_function_wrt_surface_pressure
as possible input variable name for exner for backwards compatibility with old converted snapshotscloses #215 (add optional register phase)
closes #286 (Improve error message returned by XML linter)
Describe any changes made to build system: None
Describe any changes made to the namelist: None
List any changes to the defaults for the input datasets (e.g. boundary datasets): None
List all files eliminated and why: None
List all files added and what they do: None
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>
)M .gitmodules
M src/control/cam_comp.F90
M src/physics/utils/phys_comp.F90
M src/data/generate_registry_data.py
M src/data/registry.xml
If there are new failures (compared to the
test/existing-test-failures.txt
file),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima: all pass
derecho/gnu/aux_sima: all pass
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced: N/A
CAM-SIMA date used for the baseline comparison tests if different than latest: