Initial pFUnit Integration #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks for getting this implemented @mwaxmonsky! I did have a few change requests, but hopefully nothing that is too difficult.
nusbaume
requested changes
Dec 7, 2024
nusbaume
approved these changes
Dec 14, 2024
jimmielin
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Thanks @mwaxmonsky! This looks great. I have a couple of minor comments that don't have to hold up the PR.
- Could the directory restructure be noted in the main text of the PR (list of modified files?) to document the purpose of the changes to the python unit test files?
- I understand this is just an initial pfUnit integration. It would be nice to have a test in the future for
stringifywhich is what's slowly replacingto_strin CAM-SIMA, but it doesn't necessarily have to be in this PR. - I saw some functions were removed from
string_utils.F90so I would just make sure all regression tests build & run as expected with the removal of these unused functions.
mattldawson
added a commit
that referenced
this pull request
Dec 31, 2024
Tag name (required for release branches): Originator(s): Matt Dawson Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number): Adds the calculation of solar zenith angle and Earth–Sun distance and makes them available as CCPP standard named variables. @nusbaume - I wasn't sure if I put the call to recalculate the orbital properties is correct. If it isn't let me know, and I can move it. closes #328 Additionally: - adds some stubbed-out dependencies needed for MUSICA, until the actual values are available from other physics schemes or the host model - adds some testing infrastructure needed for unit tests of this code. Once #326 is merged in, I can update this PR to use the new unit testing infrastructure In draft until ESCOMP/atmospheric_physics#171 is merged in Describe any changes made to build system: none Describe any changes made to the namelist: none List any changes to the defaults for the input datasets (e.g. boundary datasets): none List all files eliminated and why: none List all files added and what they do: List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) If there are new failures (compared to the `test/existing-test-failures.txt` file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff? derecho/intel/aux_sima: derecho/gnu/aux_sima: If this changes climate describe any run(s) done to evaluate the new climate in enough detail that it(they) could be reproduced: CAM-SIMA date used for the baseline comparison tests if different than latest: --------- Co-authored-by: Courtney Peverley <[email protected]> Co-authored-by: Kuan-Chih Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @mwaxmonsky
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Describe any changes made to build system: None
Describe any changes made to the namelist: None
List any changes to the defaults for the input datasets (e.g. boundary datasets): None
List all files eliminated and why: None
List all files added and what they do:
A .github/workflows/fortran_unit_tests.yml
A src/core_utils/CMakeLists.txt
A test/unit-fortran/CMakeLists.txt
A test/unit-fortran/src/core_utils/CMakeLists.txt
A src/core_utils/string_core_utils.F90
A test/unit-fortran/src/core_utils/test_string_core_utils.pf
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)M src/utils/string_utils.F90
If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: