Update standard names for tropopause_find #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmielin
added
the
code clean-up
nusbaume
approved these changes
Dec 13, 2024
peverwhee
approved these changes
Dec 13, 2024
|
Thanks @nusbaume and @peverwhee for reviewing! This is ready for merge, I'll hold on until #316 is merged and the regression tests can run so I can bring this in. |
jimmielin
added a commit
to ESCOMP/atmospheric_physics
that referenced
this pull request
Dec 16, 2024
Fixes ESCOMP/CAM-SIMA#308 Requires a companion PR in CAM-SIMA to update the standard name of `tropp_slices` there as well: ESCOMP/CAM-SIMA#329
|
Regression tests passed (subject to existing failures) - no changes to baselines Updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @jimmielin
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Fixes #308 by updating tropopause_find standard names.
Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)Updates standard names for tropopause_find
M src/physics/utils/tropopause_climo_read.F90
M src/physics/utils/tropopause_climo_read.meta
If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: