Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update teout standard name for check_energy; bring in check_energy diagnostic output #339

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

jimmielin
Copy link
Member

@jimmielin jimmielin commented Dec 16, 2024

Holding until CAM7 tests run so this can be tested at runtime

Tag name (required for release branches):
Originator(s): @jimmielin

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

Closes ESCOMP/atmospheric_physics#161, ESCOMP/atmospheric_physics#166, ESCOMP/atmospheric_physics#176:

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

Updates teout standard name to vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep
M       src/data/registry.xml
M       src/dynamics/mpas/dyn_comp.F90
M       src/dynamics/none/dyn_grid.F90
M       src/dynamics/se/dyn_comp.F90

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima:

derecho/gnu/aux_sima:

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@jimmielin jimmielin added the code clean-up Made code simpler, better, and/or easier to read. label Dec 16, 2024
@jimmielin jimmielin self-assigned this Dec 16, 2024
@jimmielin jimmielin marked this pull request as draft December 16, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code clean-up Made code simpler, better, and/or easier to read.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant