fix real32 gnu issue

[peverwhee]

Tag name (required for release branches): sima0_0_003
Originator(s): peverwhee

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Select correct field_data buffer (r8 vs r4) depending on the precision of the file in question
closes #336 "History using REAL32 does not appear to write properly"
closes #341 "History code always outputs an "empty" zero timestep"
addresses #343 "Add intel snapshot testing"

Describe any changes made to build system: n/a

Describe any changes made to the namelist: n/a

List any changes to the defaults for the input datasets (e.g. boundary datasets): n/a

List all files eliminated and why: n/a

List all files added and what they do: n/a

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M src/history/cam_hist_file.F90

• add r4 array and use that conditionally if precision is REAL32
• fix bug where the sample number was being incremented twice

M test/existing-test-failures.txt

• update test failures file to point to framework PR we're waiting on

M cime_config/testdefs/testlist_cam.xml

• remove intel snapshot tests since we don't currently have any intel snapshots!

M cime_config/testdefs/testmods_dirs/cam/outfrq_kessler_derecho/user_nl_cam

• remove min_difference that was added to get the intel test (that no longer exist) to run

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima: All DIFF because of the nstep=0 bug, but confirmed that the results were b4b with a slice of the baselines (removing the erroneous nstep=0 sample)

derecho/gnu/aux_sima: All DIFF because of the nstep=0 bug, but confirmed that the results were b4b with a slice of the baselines (removing the erroneous nstep=0 sample)

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

[nusbaume]

Thanks for the bug fixes! I had a few optional requests but they certainly aren't necessary if they start to hold up this PR.

[nusbaume]

Didn't we recently learn that you don't need to trim the string variable in order to do the string comparison? If so then I would vote to remove the trim calls here and below.

[peverwhee]

I think that's only true for comparison vs an array of strings (e.g. "any" syntax) where you don't have to trim each array element. Like:

if (any(freq_types_to_check == trim(this%output_freq_type))) then

but i may be misremembering!

[nusbaume]

Now that check_allocate supports passing in errmsg as well can we do that here and below? Thanks!

[peverwhee]

added!

[nusbaume]

If we know frank equals one then I think we can simplify this slightly to the following:

Suggested change

	call cam_grid_write_dist_array(this%hist_files(split_file_index), field_decomp, dim_sizes(1: frank), &
	field_shape, field_data_r4(:,1), varid)
	else
	call hist_buffer_norm_value(buff_ptr, field_data_r8(:,1))
	call cam_grid_write_dist_array(this%hist_files(split_file_index), field_decomp, dim_sizes(1: frank), &
	call cam_grid_write_dist_array(this%hist_files(split_file_index), field_decomp, dim_sizes(1), &
	field_shape, field_data_r4(:,1), varid)
	else
	call hist_buffer_norm_value(buff_ptr, field_data_r8(:,1))
	call cam_grid_write_dist_array(this%hist_files(split_file_index), field_decomp, dim_sizes(1), &

[peverwhee]

cam_grid_write_dist_array is expecting an array, so updated to

field_decomp, (/dim_sizes(1)/),

[nusbaume]

Very silly nit-pick but can we remove the space between 1: and frank here?

Suggested change

	call cam_grid_write_dist_array(this%hist_files(split_file_index), field_decomp, dim_sizes(1: frank), &
	field_shape, field_data_r4, varid)
	else
	call hist_buffer_norm_value(buff_ptr, field_data_r8)
	call cam_grid_write_dist_array(this%hist_files(split_file_index), field_decomp, dim_sizes(1: frank), &
	call cam_grid_write_dist_array(this%hist_files(split_file_index), field_decomp, dim_sizes(1:frank), &
	field_shape, field_data_r4, varid)
	else
	call hist_buffer_norm_value(buff_ptr, field_data_r8)
	call cam_grid_write_dist_array(this%hist_files(split_file_index), field_decomp, dim_sizes(1:frank), &

[peverwhee]

the picked nit has been squashed (?)

...updated