-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add version.txt and github workflow to update file. #208
Conversation
@erik - this uses a github action added to bumpversion.yml to write the version to a file version.txt on push to main. That file is read by ./checkout_externals --version |
I realized that I need to update the version.txt file before generating the tag but I need to get the new tag name before updating the file - this action does that. Tested in https://github.com/jedwards4b/testrepo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is okay if it really works. It is a lot harder to try to figure out the new Microsoft TypeScript (:grimacing:) then the first (shell) version.
@@ -0,0 +1 @@ | |||
manic-1.2.24-3-gba00e50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to get cleaned up when it is tagged?
I.s., will it be manic-1.2.25
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it will be manic-1.2.25.
add a version.txt file and a --version option to checkout_externals
Adds a pre-push hook to update the file version.txt when you push to the repository.
User interface changes?: Yes
Adds --version option
Fixes: #207
Testing:
test removed:
unit tests: All pass
system tests: All pass
manual testing: ./checkout_externals --version