Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce multiple file upload app enhancements #1

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Introduce multiple file upload app enhancements #1

wants to merge 13 commits into from

Conversation

a1eksb
Copy link

@a1eksb a1eksb commented Jul 11, 2024

This pull request introduces the following Django file upload app enhancements:

  • Make file owner property optional: There are use cases where the files are not tightly tied to an owner but to other entities (for example a project in case of BMIP)
  • Introduce deleted_on property: In some cases we may want to keep files and simply not show them after deletion. For such cases it makes sense to keep a deleted_on date.
  • Introduce max_file_size property: In some cases we want to check the file size and make sure files larger than the max file size are not uploaded.
  • Fix a bug where file batch is being accessed via file_upload.batch instead of file_upload.file_upload_batch

Additionally it also introduces a draft of the new documentation.

@a1eksb a1eksb requested review from dameyerdave and olloz26 and removed request for dameyerdave July 11, 2024 12:51
@a1eksb
Copy link
Author

a1eksb commented Jul 11, 2024

I realized only one reviewer can be assigned so @dameyerdave please also check it out and let me know if you have additional ideas / suggestions.

@a1eksb
Copy link
Author

a1eksb commented Jul 19, 2024

Once merged we also need to add the server entry for docs.

@olloz26
Copy link
Collaborator

olloz26 commented Jul 30, 2024

Commit messages: No space before or after a bracket, e.g. [FEAT] instead of [ FEAT ]. See: https://unlimited.ethz.ch/pages/viewpage.action?spaceKey=nexuswiki&title=Git+Conventions

@a1eksb
Copy link
Author

a1eksb commented Jul 30, 2024

Thanks for the feedback @olloz26 ! I modified my dev environment settings to have all commits with no spaces before / after brackets. 😁

@olloz26
Copy link
Collaborator

olloz26 commented Jul 31, 2024

The [] are not my invention. Do you know https://www.conventionalcommits.org 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants