Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac compile patch for AltMath #104

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Mac compile patch for AltMath #104

merged 1 commit into from
Dec 30, 2024

Conversation

michael-petersen
Copy link
Member

I missed this in the recent merge of #101: the cylindrical Bessel function issue bit me again on Mac.

Also one piece of cruft can be removed.

@The9Cat
Copy link
Contributor

The9Cat commented Dec 30, 2024

Good find on dead.letter. It must be mine but I don't know how it got there!

The fix looks fine to me. Another option is to remove expontest.cc altogether as it is really a sanity check on the Hankel transform and has doesn't add any functionality to any EXP-based work flow.

@michael-petersen
Copy link
Member Author

Yes, I was also wondering if expontest.cc could just be removed. It could potentially be helpful in a force-accuracy test for Cylinder as well, right? In which case it might make sense to keep it.

@The9Cat
Copy link
Contributor

The9Cat commented Dec 30, 2024

It is a standalone example for the PotRZ class (which makes a 3d gravitational potential from a 2d polar density) using the underlying QDHT Hankel transform class. So, yes, perhaps it's worth keeping as a usage case?

Okay, I'm convinced. Let's merge it.

@The9Cat The9Cat merged commit 551a43f into main Dec 30, 2024
8 checks passed
@The9Cat The9Cat deleted the AltMathPatch branch December 30, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants