Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Right swings now work without flipping rotation axis #262

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

ssejrog
Copy link
Member

@ssejrog ssejrog commented Jan 1, 2025

Summary:

Right swings now work.

Motivation:

Without the rotation axis flipped, all swings were left swings.

References (optional):

Test Plan:

  • ensure the following code works as expected
chassis.pid_swing_set(ez::LEFT_SWING, -45_deg, 110, 55);
chassis.pid_wait();

chassis.pid_swing_set(ez::LEFT_SWING, 0_deg, 110, 55);
chassis.pid_wait();

chassis.pid_swing_set(ez::RIGHT_SWING, -45_deg, 110, 55);
chassis.pid_wait();

chassis.pid_swing_set(ez::RIGHT_SWING, 0_deg, 110, 55);
chassis.pid_wait();
  • ensure the above code still works when this is added to the start
chassis.odom_theta_flip();

Download the template for this pull request:

Note

This is auto generated from Add Template to Pull Request

curl -o [email protected]+5e7261.zip https://nightly.link/EZ-Robotics/EZ-Template/actions/artifacts/2375403930.zip;
pros c fetch [email protected]+5e7261.zip;
pros c apply [email protected]+5e7261;
rm [email protected]+5e7261.zip;

@ssejrog ssejrog changed the title Right swings should now work 🐛 Right swings now work without flipping rotation axis Jan 1, 2025
@ssejrog ssejrog self-assigned this Jan 1, 2025
@ssejrog ssejrog merged commit e185558 into dev Jan 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant