Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Add missing claims parameters, fix interdependency parameter enforcement #603

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

nwithan8
Copy link
Member

Description

  • Add missing ACH payment method type for claims
  • Add missing CheckDeliveryAddress parameter for creating a claim
    • Require CheckDeliveryAddress if PaymentMethod is MailedCheck
    • Account for enums when enforcing interdependence of parameters*

*An unfortunate side effect of the custom enum classes used throughout the project, these cannot be passed into an attribute because they are not available at compile-time (unlike traditional enums). Instead, the attribute is provided the underlying primitive (string, float, int, etc.) value that is expected, and a pre-comparison check will convert any custom enum to its own underlying value, ensuring that the underlying primitive values are what is being compared in the interdependency check.

Testing

  • Added unit test to confirm interdependency enforcement works as expected with enum parameters

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team as a code owner November 15, 2024 23:34
@nwithan8 nwithan8 merged commit b738965 into master Nov 18, 2024
14 checks passed
@nwithan8 nwithan8 deleted the claims branch November 18, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants