Maniacs Patch - Call System Functions #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Maniacs, CommandOpenSaveMenu is renamed to "Call System Function". I implemented what is closer to our code. Also expanded the code to cover our custom submenus (Cases 8 to 12). Update game_interpreter_map.cpp
jetrotal
force-pushed
the
Maniacs-Call-System-Functions
branch
4 times, most recently
from
51e1747 to
0c7528a
Compare
Ghabry
reviewed
Aug 1, 2024
src/game_interpreter_map.cpp
Outdated
|
|
||
| // Parse common parameters | ||
| const int fullscreen_mode = com.parameters[1]; // Broken in Maniac. | ||
| const int pause_while_debugging = com.parameters[1]; // unused in our ingame debug screen. |
There was a problem hiding this comment.
Maniacs reuses parameter[1] in different cases, I just gave names to the parameters to be easier to read and understand.
src/game_interpreter_map.cpp
Outdated
| return true; | ||
| case 7: // Reset game | ||
| return CommandReturnToTitleScreen(com); | ||
| case 8: // EASYRPG Inventory menu |
There was a problem hiding this comment.
Is it intentional that an enabled direct menu patch can redirect these menu calls? (the dmpatch redirection is in RequestMainMenuScene)
|
I will move the EasyRPG extension stuff to a higher ID like 200 onwards to prevent conflicts with upcoming MP version. Otherwise this is fine imo. |
…ent conflicts Minor enhancements
27 tasks
fdelapena
approved these changes
Aug 25, 2024
Ghabry
force-pushed
the
Maniacs-Call-System-Functions
branch
from
d7da825 to
99188a1
Compare
Ghabry
force-pushed
the
Maniacs-Call-System-Functions
branch
from
99188a1 to
a2080c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Maniacs, CommandOpenSaveMenu is renamed to "Call System Function". I implemented what is closer to our code.
Also expanded the code to cover our custom submenus (Cases 8 to 12).