Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Always check isMessageActive() at the beginning in game_Int… #3253

Merged
merged 3 commits into from
Sep 1, 2024
Merged

Refactor: Always check isMessageActive() at the beginning in game_Int… #3253

merged 3 commits into from
Sep 1, 2024

Conversation

lychees
Copy link
Contributor

@lychees lychees commented Aug 11, 2024

No description provided.

Ghabry
Ghabry approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@Ghabry Ghabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only moves local variables closer to their usage loc and removes a useless func so looks good to me.

@Ghabry Ghabry added this to the 0.8.1 milestone Aug 24, 2024
@Ghabry Ghabry requested a review from fdelapena September 1, 2024 20:57
@fdelapena fdelapena merged commit fb5d659 into EasyRPG:master Sep 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ghabry Ghabry Ghabry approved these changes

@fdelapena fdelapena fdelapena approved these changes

Assignees
No one assigned
Labels
Event/Interpreter Refactor
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@lychees @fdelapena @Ghabry