Fix issue 3135 (second try) by exhausting the fluidsynth buffer #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld samples after long pauses Fix EasyRPG#3135 (this time for real)
fdelapena
approved these changes
Sep 1, 2024
|
Seems to work for me 👍 |
|
I think the only case where this can sound slightly different is when a song ends and a new song plays directly then a few ms of the old song that are still in the buffer are lost. Though our API does not have a way to signal "This is a song change" and stuff like "BGM Stop event followed by BGM play right after" wouldn't be catched by this. So not worth to add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Mimigris works for me ?!