-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Maniacs Command 3010: ControlATBGauge #3291
Merged
Merged
+92
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghabry
added
Battle
Has PR Dependencies
This PR depends on another PR
and removed
Window/Scenes
Building
labels
Nov 7, 2024
Ghabry
requested changes
Nov 7, 2024
fdelapena
approved these changes
Nov 7, 2024
Please rebase to get rid of the merge commits:
|
MakoInfused
force-pushed
the
ManiacControlATBGauge
branch
from
November 8, 2024 10:25
3a29899
to
4d3feae
Compare
Rebase result looks good 👍 |
27 tasks
Ghabry
reviewed
Nov 8, 2024
Ghabry
reviewed
Nov 8, 2024
Ghabry
reviewed
Nov 9, 2024
Ghabry
approved these changes
Nov 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the warning is fixed looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the maniacs patch ControlATBGauge with something like this:
Will result in all party members having 1/3rd of a full gauge.
Or using it with 100% ATB for the first party member:
Would result in this:
Of course developers can use any combination of parameters, I've tested all of them individually with all combinations.
I've also recreated the functionality from maniacs where when a 0 index is passed in as an actor id, it just ignores the command entirely.