Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOS-958] Replace built-in functions list and map with first-class syntax #7

Closed
wants to merge 1 commit into from
Closed

[DOS-958] Replace built-in functions list and map with first-class syntax #7

wants to merge 1 commit into from

Conversation

sergiocharpineljr
Copy link

@sergiocharpineljr sergiocharpineljr requested a review from a team as a code owner March 27, 2024 17:28
@sergiocharpineljr sergiocharpineljr requested review from sgmac, jamestait, horia-alungulesei, ebury-sergiorobles and DaniGordillo and removed request for a team March 27, 2024 17:28
@sergiocharpineljr
Copy link
Author

sergiocharpineljr commented Mar 27, 2024 •
edited
Loading

@Ebury/pc we are using this only in https://github.com/Ebury/terraform-module-aws-eks/blob/f4e069c1d638ba118c28ce4b62ce48d783ae2438/eks.tf#L11. It's pointing to a static tag which is not supported by TF v0.15+. The fixes are on this PR but not sure how to propagate to that module if I merge this to master.
What is the best approach to make this repo compatible?

@sergiocharpineljr sergiocharpineljr deleted the DOS-958 branch April 1, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgmac sgmac sgmac approved these changes

@jamestait jamestait Awaiting requested review from jamestait jamestait is a code owner automatically assigned from Ebury/platform-kubernetes-codeowners

@horia-alungulesei horia-alungulesei Awaiting requested review from horia-alungulesei horia-alungulesei is a code owner automatically assigned from Ebury/platform-kubernetes-codeowners

@ebury-sergiorobles ebury-sergiorobles Awaiting requested review from ebury-sergiorobles ebury-sergiorobles is a code owner automatically assigned from Ebury/platform-kubernetes-codeowners

@DaniGordillo DaniGordillo Awaiting requested review from DaniGordillo DaniGordillo is a code owner automatically assigned from Ebury/platform-kubernetes-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiocharpineljr @sgmac